Merged
Conversation
github-actions
bot
added
the
linter
foolip
approved these changes
Jun 24, 2021
Contributor
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I think we should do this 👍
Contributor
|
This is going to need documentation changes: https://github.com/mdn/browser-compat-data/blob/main/schemas/compat-data-schema.md#ranged-versions |
github-actions
bot
added
docs
foolip
reviewed
Jun 24, 2021
| @@ -275,6 +275,7 @@ For certain browsers, ranged versions are allowed as it is sometimes impractical | |||
| - "≤79" (supported in some version Chromium-based Edge and possibly in EdgeHTML-based Edge) | |||
Contributor
There was a problem hiding this comment.
I notice this documentation is misleading. It's not in "some" version of Chromium-based Edge, to use this range one has to test Edge 79 specifically.
Same issue with Opera 15 range.
We should probably remove those ranges :)
foolip
approved these changes
Jun 24, 2021
Contributor
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Anyway, the added docs look good.
lucalves
approved these changes
Jul 5, 2021
Contributor
|
Ping @ddbeck for review. |
Elchi3
approved these changes
Aug 3, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Aug 3, 2021
ddbeck
added a commit
that referenced
this pull request
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
≤11as a valid range for Internet Explorer. With IE's market share now less than 1%, along with the age of its releases, I don't think most developers will care about how far back something has been supported in IE (or in most cases, IE support altogether). Additionally, this will aid in speeding up the removal of null and true values.This PR is inspired by a comment from @foolip in #10381.