Demix AbstractWorker↠ Worker/SharedWorker/ServiceWorker.onerror#10744
Merged
sideshowbarker merged 1 commit intomdn:mainfrom Jun 7, 2021
Merged
Demix AbstractWorker↠ Worker/SharedWorker/ServiceWorker.onerror#10744sideshowbarker merged 1 commit intomdn:mainfrom
sideshowbarker merged 1 commit intomdn:mainfrom
Conversation
github-actions
bot
added
the
data:api
Tests: https://staging-dot-mdn-bcd-collector.appspot.com/tests/api/Worker/onerror https://staging-dot-mdn-bcd-collector.appspot.com/tests/api/SharedWorker/onerror https://mdn-bcd-collector.appspot.com/tests/api/ServiceWorker/onerror (prototype test only) Manually confirmed: - Worker.onerror and SharedWorker.onerror in Chrome 15 - *.onerror in Edge 80 - ServiceWorker.onerror in Firefox 44 - *.onerror in Firefox Android 80 - Worker.onerror and SharedWorker.onerror in Opera 12.16 - ServiceWorker.onerror in Safari 11.1 Also, the onerror attribute was in WebKit source at the time of the initial release of Worker and SharedWorker, respectively: https://trac.webkit.org/browser/webkit/releases/Apple/Safari%204.0/WebCore/workers/Worker.idl?rev=135093 https://trac.webkit.org/browser/webkit/releases/Apple/Safari%205.0/WebCore/workers/AbstractWorker.idl?rev=135093 From this we can also glean that AbstractWorker was at one point an abstract base interface and not a mixin, but that doesn't matter. Beyond this testing, much of the data is assumed to match the parent entries, and the data ends up matching (modulo notes) for SharedWorker and ServiceWorker. For Worker the only difference is the nodejs data, which is set to false like onmessage and onmessageerror, rather than working out the correct versions from the documentation: https://nodejs.org/api/worker_threads.html#worker_threads_event_error
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 3, 2021
This creates 3 individual onerror pages with different wording and examples. BCD demixing: mdn/browser-compat-data#10744
Contributor
Author
|
MDN cleanup is here: mdn/content#5622 |
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 4, 2021
This creates 3 individual onerror pages with different wording and examples. BCD demixing: mdn/browser-compat-data#10744
sideshowbarker
approved these changes
Jun 7, 2021
sideshowbarker
changed the title
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 9, 2021
ddbeck
added a commit
that referenced
this pull request
Jun 10, 2021
* Bump version to v3.3.7 * Add release note for #10745 * Add release note for #10686 * Add release note for #10744 * Add release note for #10820 * Add release note for #10582 * Add release note for #9464 * Add release note for #10724 * Add release note for #10827 * Add release note for #10829 * Add release note for #10782 * Add stats * Add release date * Update stats one last time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests:
https://staging-dot-mdn-bcd-collector.appspot.com/tests/api/Worker/onerror
https://staging-dot-mdn-bcd-collector.appspot.com/tests/api/SharedWorker/onerror
https://mdn-bcd-collector.appspot.com/tests/api/ServiceWorker/onerror (prototype test only)
Manually confirmed:
Also, the onerror attribute was in WebKit source at the time of the
initial release of Worker and SharedWorker, respectively:
https://trac.webkit.org/browser/webkit/releases/Apple/Safari%204.0/WebCore/workers/Worker.idl?rev=135093
https://trac.webkit.org/browser/webkit/releases/Apple/Safari%205.0/WebCore/workers/AbstractWorker.idl?rev=135093
From this we can also glean that AbstractWorker was at one point an
abstract base interface and not a mixin, but that doesn't matter.
Beyond this testing, much of the data is assumed to match the parent
entries, and the data ends up matching (modulo notes) for SharedWorker
and ServiceWorker. For Worker the only difference is the nodejs data,
which is set to false like onmessage and onmessageerror, rather than
working out the correct versions from the documentation:
https://nodejs.org/api/worker_threads.html#worker_threads_event_error