Require added+removed versions to make sense when ignoring ranges#10710
Require added+removed versions to make sense when ignoring ranges#10710
Conversation
|
@ddbeck @Elchi3 I'd love your thoughts on this. I put this together while thinking about #10653 (comment), and this stricter lint would cause some changes in that PR to fail. Since MDN now drops the ≤ I think BCD should require the data to be sensible even if ignoring ranges. |
|
I think this makes sense. I definitely didn't think about this when we changed the MDN rendering. Good catch! |
|
@Elchi3 do you feel like reviewing? |
|
I'm kinda neutral on this idea, though I won't stand in the way of it. I agree that it's not good when the data looks like this, but it's not clear to me that this is a presentation problem, rather than a problem with the data itself. |
|
So, in terms of the data this makes things only stricter by disallowing the following case, right? version_added: "≤37" It is valid data but by disallowing it would then prompt the BCD author to avoid "≤37" leading to a real value that doesn't involve "≤" (which is better data). Other side effects here? If not, then I would say we should go with this. |
The one I can think of is someone adding less-accurate data (e.g., setting |
|
@Elchi3 there's also cases like this that this would disallow: version_added: "≤37" |
Elchi3
left a comment
There was a problem hiding this comment.
That case seems reasonable to disallow to me, too.
Let's do this. (we just had a release, so if this is problematic, I guess we would notice way before next Thursday).
|
Thanks @Elchi3! @vinyldarkscratch now that this is landed, it would be good to revisit that WebView SVG weirdness and resolve it in a way that doesn't break this lint rule. |
This PR adds real values for WebView Android for the `MouseEvent` API. The data was mirrored from Chrome/Safari and determined based upon the WebKit version. I'm not able to set the version added to "≤37" because the version removed is "37" -- the linter will fail due to the changes made in mdn#10710.
No description provided.