Demix SVGFilterPrimitiveStandardAttributes#10646
Merged
Conversation
Data from (confirmed by) mdn-bcd-collector: - Chrome ≤15 - Edge 12 / 79 - Firefox ≤4 - Firefox Android ≤86 - IE 10 - Opera ≤12.1 / 15 - Safari 6 - Safari iOS ≤10.3 Chrome ≤15 is assumed to be 5 in most cases where it was 5 here: mdn#7197 Firefox ≤4 is assumed to be 3 based on: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/3 Mirrored data: - Firefox Android 4 - Opera Android ≤12.1 / 14 - Safari iOS 6 - Samsung Internet 1.0 - WebView Android ≤37 Most of the data is very regular. Notable exceptions: - SVGFEConvolveMatrixElement entries are assumed to have shipped in Chrome 6, like api.SVGFEConvolveMatrixElement and its subfeatures. - SVGFEDropShadowElement was shipped in Chrome 13 / Firefox 30, and seemingly never supported in IE, EdgeHTML or Presto. - In Firefox, something strange happened with 3 of the interfaces. In Firefox 21, almost all subfeatures of these tests pass: http://mdn-bcd-collector.appspot.com/tests/api/SVGFEComponentTransferElement http://mdn-bcd-collector.appspot.com/tests/api/SVGFEFloodElement http://mdn-bcd-collector.appspot.com/tests/api/SVGFEGaussianBlurElement (except edgeMode) In Firefox 22, the height/result/width/x/y fail. They're back in Firefox 29/35. This looks like a mishap, but is captured in the data anyway.
foolip
commented
May 27, 2021
api/_mixins/SVGFilterPrimitiveStandardAttributes__SVGFEBlendElement.json
Show resolved
Hide resolved
Elchi3
requested changes
May 28, 2021
Member
Elchi3
left a comment
There was a problem hiding this comment.
Thanks, this is quite impressive. Maybe the largest PR that submits complete real data? (no true or null in here, so great!)
I trust the BCD collector and the mirroring makes sense to me, too. Thanks for also getting into some of the exceptions.
The only change request I have is to please add mdn_urls to the main interfaces at least. The sub features will all be 404, so let's not add these, but I think all the interfaces are present on MDN.
Contributor
Author
|
Do you mean that I should add |
Member
|
Oh wait, I'm stupid. The interfaces have their mdn_urls anyways already. This is mixins! Nevermind! 😊 |
Elchi3
approved these changes
May 28, 2021
Contributor
Author
|
Thanks for review @Elchi3! |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 2, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 2, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 3, 2021
ddbeck
added a commit
that referenced
this pull request
Jun 4, 2021
* Bump version to v3.3.6 * Add release note for #10646 * Add release note for #10581 * Add release note for #10685 * Add release note for #10691 * Add release note for #6957 * Add release note for #10721 * Add release note for #10695 * Add release note for #9821 * Add release note for #10681 * Add release note for #10725 * Add stats * Add release date * Wordsmith
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data from (confirmed by) mdn-bcd-collector:
Chrome ≤15 is assumed to be 5 in most cases where it was 5 here:
#7197
Firefox ≤4 is assumed to be 3 based on:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/3
Mirrored data:
Most of the data is very regular. Notable exceptions:
SVGFEConvolveMatrixElement entries are assumed to have shipped in
Chrome 6, like api.SVGFEConvolveMatrixElement and its subfeatures.
SVGFEDropShadowElement was shipped in Chrome 13 / Firefox 30, and
seemingly never supported in IE, EdgeHTML or Presto.
In Firefox, something strange happened with 3 of the interfaces. In
Firefox 21, almost all subfeatures of these tests pass:
http://mdn-bcd-collector.appspot.com/tests/api/SVGFEComponentTransferElement
http://mdn-bcd-collector.appspot.com/tests/api/SVGFEFloodElement
http://mdn-bcd-collector.appspot.com/tests/api/SVGFEGaussianBlurElement (except edgeMode)
In Firefox 22, the height/result/width/x/y fail. They're back in Firefox
29/35. This looks like a mishap, but is captured in the data anyway.