Add IE versions for KeyboardEvent API#10381
Conversation
This PR adds real values for Internet Explorer and Edge for the `KeyboardEvent` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.0.2). Results are manually confirmed for accuracy. Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/KeyboardEvent
|
This seems suspicious. Keyboard events of some kind must have been supported since IE 4 and maybe earlier. Can you do some digging? |
|
Running a little test code (see below), it isn't until IE 9 that I see the document.onkeydown = function(event) {
alert(event);
} |
|
@vinyldarkscratch if you omit the Alternatively, you could try the |
|
It appears that in IE 10 and below, With all of this in mind, I think that setting this event API to IE 9 is correct. |
|
Thanks @vinyldarkscratch! If we have a lot of event data to work through, and if some big events rewrite was in IE9, maybe we should go with a <=IE9 range and not bother testing earlier. Or just <=IE11 would be fine honestly. |
|
Just checking to see if there's anything I need to do to get this PR ready for merging? |
|
I had suggested a <=9 range, but given that I just merged the MouseEvent PR this seems very plausible too. Nobody will care if it's right anyway, who's supporting IE8 now? |
This PR adds real values for Internet Explorer and Edge for the
KeyboardEventAPI, based upon results from the mdn-bcd-collector project (v3.0.2). Results are manually confirmed for accuracy.Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/KeyboardEvent