Conversation
We have 61 features with https://www.khronos.org/registry/webgl/extensions/ spec URLs. All https://www.khronos.org/registry/webgl/extensions/ specs lack any ID/anchors at all, and therefore don’t conform to the JSON schema requirement in the compat-data.schema.json file for spec_url values to have a fragment identifier. So this change updates the schema to allow any URLs matching the following pattern: ^https://www.khronos.org/registry/webgl/extensions/[^/]+/ Otherwise, without this change, our CI fails on all those URLs, because it expects to find the required fragment identifier in each of them.
github-actions
bot
added
the
schema
Member
|
Looks good to me. I opened mdn/yari#3746 just to be sure rendering will never break (The |
Elchi3
approved these changes
May 10, 2021
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Yari PR merged.
I will talk to Daniel about this change, but looks good to me.
ddbeck
requested changes
May 10, 2021
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
The changes in the diff look fine to me, but the corresponding text in compat-data-schema.md needs updating, too.
github-actions
bot
added
the
docs
Member
Author
OK, thanks — added now |
sideshowbarker
deleted the
sideshowbarker/compat-data.schema.json-allow-WebGL-extension-spec-URLs
branch
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
May 20, 2021
ddbeck
added a commit
that referenced
this pull request
May 20, 2021
* Bump version to v3.3.4 * Add release note for #10353 * Add release note for #10347 * Add release note for #10336 * Add release note for #10415 * Add release note for #10417 * Add release note for #10449 * Add release note for #9933 * Add release note for #10354 * Add release notes for #6944 * Add release note for #10522 * Add release note for #10536 * Add release note for #10539 * Add release note for #10515 * Add release note for #10506 * Add release note for #10291 * Add release note for #10421 * Add release note for #10545 * Add stats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We’re at the point where we need to add spec URLs for 61 WebGL features from https://www.khronos.org/registry/webgl/extensions/ WebGL extension specs.
But all https://www.khronos.org/registry/webgl/extensions/ specs lack any ID/anchors at all, and therefore don’t conform to the JSON schema requirement in the compat-data.schema.json file for
spec_urlvalues to have a fragment identifier. So this change updates the schema to allow any URLs matching the following pattern:Otherwise, without this change, CI fails on all those URLs, because doesn’t find the required fragment IDs in them.
#10358 is the related data change.