Skip to content

Comments

Move api.Navigator.geolocation.hid to api.Navigator.hid#10291

Merged
ddbeck merged 2 commits intomdn:mainfrom
bershanskiy:api.Navigator.hid
May 20, 2021
Merged

Move api.Navigator.geolocation.hid to api.Navigator.hid#10291
ddbeck merged 2 commits intomdn:mainfrom
bershanskiy:api.Navigator.hid

Conversation

@bershanskiy
Copy link
Contributor

@bershanskiy bershanskiy commented May 5, 2021

Move api.Navigator.geolocation.hid to api.Navigator.hid beacuse it's actually accessed via navigator.hid. I think it was caused by a misplaced }.

While at it, fix MDN URL as well.

One example from WebHID API:

navigator.hid.addEventListener('connect', ({device}) => {
  console.log(`HID connected: ${device.productName}`);
});

Also, note that the relevant MDN page uses the correct name api.Navigator.hid (so compat table is broken right now, but will be fixed by this PR).

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 5, 2021
@bershanskiy bershanskiy marked this pull request as draft May 5, 2021 12:12
@bershanskiy bershanskiy marked this pull request as ready for review May 5, 2021 12:17
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit f318538 into mdn:main May 20, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 20, 2021
ddbeck added a commit that referenced this pull request May 20, 2021
* Bump version to v3.3.4
* Add release note for #10353
* Add release note for #10347
* Add release note for #10336
* Add release note for #10415
* Add release note for #10417
* Add release note for #10449
* Add release note for #9933
* Add release note for #10354
* Add release notes for #6944
* Add release note for #10522
* Add release note for #10536
* Add release note for #10539
* Add release note for #10515
* Add release note for #10506
* Add release note for #10291
* Add release note for #10421
* Add release note for #10545
* Add stats
@bershanskiy bershanskiy deleted the api.Navigator.hid branch May 20, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants