Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New metrics #25

Merged
merged 3 commits into from
Jul 15, 2022
Merged

New metrics #25

merged 3 commits into from
Jul 15, 2022

Conversation

mkotsalainen
Copy link
Contributor

I've added some 3 metrics that rq exposes:

  • successful_job_count
  • failed_job_count
  • total_working_time

By dividing total_working_time by successful_job_count and failed_job_count you can get avg task latency which is useful to track.

Matti Kotsalainen added 3 commits July 12, 2022 12:04
@mkotsalainen mkotsalainen mentioned this pull request Jul 15, 2022
Closed
@mdawar
Copy link
Owner

mdawar commented Jul 15, 2022

Thank you for your contribution.
I'll merge this pull request, but what can you do about the current commit messages?
I haven't used squash and merge before and I don't know if it keeps you as the author of the resulting commit.

@mkotsalainen
Copy link
Contributor Author

Squash the commit. I think I should be attributed but if not, no problem on my side.
https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/

@mdawar mdawar merged commit 14634ff into mdawar:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkotsalainen @mdawar