Repository navigation
docs: note the mcp SDK stdin-EOF known limitation - #37
Merged
Merged
Conversation
A full-repo audit reproduced a real, already-tracked upstream defect (modelcontextprotocol/python-sdk#2678, open since 2026-05, 5+ unmerged fix attempts) - the SDK can drop an in-flight tool-call response if the client closes stdin before the tool finishes. A follow-up deep-research pass confirmed real-world exposure is unquantified (every reproduction used artificial batch/file-redirected stdin, not a well-behaved persistent client) and that the actual fix has to live inside the SDK, which this project cannot patch. Documenting as a known limitation rather than attempting a fragile application-level workaround. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full-repo audit reproduced a real defect in the underlying mcp SDK - it can drop an in-flight tool-call response if the client closes stdin before the tool finishes. A follow-up deep-research pass confirmed this is already tracked upstream (modelcontextprotocol/python-sdk#2678, open since 2026-05, 5+ unmerged fix attempts, no maintainer sign-off after ~4 months) and that real-world exposure is unquantified (every reproduction used artificial batch/file-redirected stdin, not a well-behaved persistent client like Claude Desktop or Claude Code).
Since the actual fix has to live inside the SDK internals and this project cannot patch a dependency, the recommendation from research was: comment on the existing upstream issue (this PR is paired with that) and document it as a known limitation here, rather than attempting a fragile application-level workaround or taking no action at all.
Test plan
🤖 Generated with Claude Code