feat: replace JSON.parse with typescript builtin config parser #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivedo
changed the title
mcollina
reviewed
Jul 13, 2024
Owner
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
This is great, but borp doesn't depend on typescript directly. You should load that dynamically.
Contributor
Author
|
Absolutely, should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #42, borp currently encounters errors when parsing
tsconfig.jsonwith comments (and more non standard JSON syntax) because it usesJSON.parseand does not support features available intsc, such as the ability to extend other configuration files.typescriptprovides a few functions to access its internal configuration parser, which can handle all of these cases and provideborpwith the exact same configuration astscwill have