fix for VisualF# issue #3729 #97
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, but Tuple`8 types are not exactly the same as a tuple of 8 elements. In order to get this to work, the F# compiler issue must be fixed. |
Contributor
There should be a reflection-based fix for this possible without relying on programming over n-tuples? |
Member
|
@dsyme I think I would rather wait until the issue gets fixed. Can always build using older versions. |
Contributor
|
Build should still work with any version of VS because the project uses FSharp.Compiler.Tools.
So ... as long as you don't update the version of FSharp.Compiler.Tools, you are safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
According to this,
dotnet/fsharp#3729
I made these changes to let this project able to be compiled with VS2017 update 15.4
Please take a look!
Regards
Anibal