Add setting to include active tab on initial ctrl+click#2083
Merged
Add setting to include active tab on initial ctrl+click#2083
Conversation
the-nelsonator
commented
Apr 6, 2025
Owner
|
Thank you! |
danielbodnar
pushed a commit
to bodnar-dev/sidebery
that referenced
this pull request
Oct 18, 2025
) * Normalize bundle paths so building on Windows works Closes mbnuqw#2078 * Tweak comment * Remove semicolon * Add setting to include active tab on initial ctrl-click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2079 (I can split if needed, just can't build without it)
Closes #2082
With the following situation:
When you ctrl+click on Tab B:
Checks that there's not an active selection so it will only include active on initial ctrl+click.
Defaulted to true, since it seems to be the standard behavior in other software including vanilla FF tabs. But Sidebery users may be used to current behavior, so we can change to default false if that's preferred.
First time adding a setting, I just plugged the English into Google Translate for the i10n so please let me know if there's a different process to follow!