Conversation
Contributor
Author
|
Hi @mbnuqw, is there anything preventing from merging the PR? Maybe I can improve or fix it. |
LucasWagler
reviewed
Mar 31, 2025
Owner
|
Thank you. There are some UX issues (user should know what data is managed and cannot be permanently changed by Sidebery) but since this feature is for advanced users I'll merge it as it is. |
n0099
added a commit
to n0099/nixos
that referenced
this pull request
Sep 14, 2025
…oaded to https://addons.mozilla.org for using managed storage to set its initial settings: mbnuqw/sidebery#2016 @ home/browser.nix
danielbodnar
pushed a commit
to bodnar-dev/sidebery
that referenced
this pull request
Oct 18, 2025
…2016) * feat: add managed storage to load functions * fix: rename stored to storedManaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds an option to configure Sideberry with a file in
~/.mozilla/managed-storage/or any other manifest location.It also resolves #1776
So for example if you want to set the sidebarCSS, you would need to create a file in a manifest location with something like that in the contents:
~/.mozilla/managed-storage/{3c078156-979c-498b-8990-85f7987dd929}.json:{ "name": "{3c078156-979c-498b-8990-85f7987dd929}", "description": "_", "type": "storage", "data": { "sidebarCSS": "#root.root {--frame-bg: #343F44;}" } }Right now i added support for these keys:
Any settings in the managed storage will overwrite the configuration in the local storage fully, except for the settings. It will overwrite only the fields that are in managed storage.