fix: search: minimum search query length in CJK should be 1.#1985
Merged
fix: search: minimum search query length in CJK should be 1.#1985
Conversation
When the query string length is 1, check whether it is a CJK character.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short, the minimum search query length required for our writing system is 1.
The reason why CJK Unified Ideographs Extension B-I are not included is because those characters are too rare... I think they can pretty much only be entered using code points directly... and therefore it is unlikely to be used for naming and searching titles.
Let's look at a simple example in Traditional Chinese:
Monday = 週一 = 星期一
Tuesday = 週二 = 星期二
Wednesday = 週三 = 星期三
Thursday = 週四 = 星期四
Friday = 週五 = 星期五
Saturday = 週六 = 星期六
Sunday = 週日 = 星期日 = 星期天
When we want to search for each day of the week, one of the situations we might want to search by just "週".