Stop changing window title on sidebar disconnect if markWindow setting is off#1835
Merged
Stop changing window title on sidebar disconnect if markWindow setting is off#1835
Conversation
…n sidebar disconnects
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using another extension https://github.com/irvinm/Toggle-Native-Tab-Bar which uses a similar technique to hide native tab bar by adding/removing a " " character from the window title. Closing the sidebar would make the native tab bar reappear even though the Sidebery setting to preface the window title was OFF. This change simply checks that setting before setting the window title to '' on a sidebar disconnect, just like it does on a sidebar connection. Unsure if this will affect anything downstream however.