Skip to content

Action on drag-and-drop to the outside of sidebar: Open in new window not working when another browser window doesn't have Sidebery open #1554

@myuwi

Description

@myuwi

Steps to reproduce

  • Open Firefox in a new profile
  • Install Sidebery
  • Open two Firefox windows, one with Sidebery visible and one with it hidden
  • Open a second tab on the one with Sidebery visible, and try to drag the tab outside the Sidebery sidebar to open it in a new window

Video:

sidebery-repro.mp4

Actual behavior

Tab doesn't open in a new window even though Action on drag-and-drop to the outside of sidebar is set to Open in new window. (default behavior)

I'm pretty sure this is caused by this Promise.all() call rejecting due to Sidebery failing to check every window for the tab's drop status (because they don't have Sidebery open).

Expected behavior

Dragged tab opens in a new window.

System

Arch Linux

Firefox version

124.0.1

Sidebery version

5.2.0

Logs

[sidebar:1] IPC.request: Cannot find appropriate port, trying to reconnect... chunk-4KZVVU6Z.js:2:7976
[sidebar:1] IPC.connectTo: No confirmation: sidebar chunk-4KZVVU6Z.js:2:7976
[sidebar:1] IPC.request: No confirmation: sidebar isDropEventConsumed chunk-4KZVVU6Z.js:2:7976
[sidebar:1] DnD.onDragEnd: Cannot get drop status from other windows
 IPC.request: No port chunk-4KZVVU6Z.js:3:25

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions