Add @go.create_gzipped_tarball and perform other small refactors #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I found myself calling `@go.add_parent_dir_if_relative_path` before `@go.canonicalize_path` quite frequently, I figured it made sense to add these flags to elide the two calls into one.
As I discovered implementing the upcoming `@go.create_gzipped_tarball`, this makes for a more natural interface. Also fixes a bug whereby I'd used `set "$BATS_DISABLE_SHELL_OPTIONS"` in the tests, when it should've been `set "$DISABLE_BATS_SHELL_OPTIONS"`.
Part of #186. Throws in the kitchen sink when it comes to sanity checks and portability.
Uses `@go.mirror_directory` from `lib/fileutil`. Also extracted an implementation helper for a slight performance boost.
After digging deeper into process substitution vs. pipes during the
implementation of `@go.mirror_directory` from `lib/fileutil`, I
realized a few things:
* The same number of processes are spawned.
* There's little benefit to a process substitution for straightforward
pipes when the output isn't consumed by the shell process.
* It's not straightforward to get the status from a process
substitution, and neither '$!' nor `wait` help.
* The 'PIPESTATUS' variable is available to check the status of each
process in the pipe, without the need for `set -o pipefail`.
Also adds a test case for `tar` failure. The 'fail to download ...' test
cases required a little tweaking to ensure they properly cover the cases
where `${download_cmd[@]}` fails.
The tests are more focused without these assertions, especially `assert_go_core_unpacked`.
6 tasks
Forgot to ensure the assertions contained `$NATIVE_LOCAL_URL`, since I'm forcing the test case to use the locally-generated tarball.
The 'fail to download ...' test cases failed on MSYS2, since those cases use a local download URL. Applying `@go.native_file_path_or_url` to the URL before making the assertions fixes the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186. Normally I would split these into separate PRs, but in the interest of putting #186 to bed and moving on, I'm eliding them here.
@go.canonicalize_pathnow accepts--pwdand--parent <dir>options for convenience, rather than forcing the caller to use@go.add_parent_dir_if_relative_pathdirectly.@go.mirror_directorynow mirrors the entire source directory by default.@go.create_gzipped_tarballthrows in tons of sanity checks and provides maximum portability, when a handful of direct commands just won't do. (The same could be said for@go.mirror_directory.)create_fake_tarball_if_not_using_real_urlnow uses@go.mirror_directory, but not@go.create_gzipped_tarball, since the latter follows the convention that the extracted directory matches the basename of the tarball. With GitHub releases, the name of the extracted directory does not match the basename of the tarball, e.g.v1.6.0.tar.gzextracts togo-script-bash-v1.6.0. So in this case, it was easier to use@go.mirror_directory, then usetardirectly, despite the fact thatcreate_fake_tarball_if_not_using_real_urlinspired@go.create_gzipped_tarball, which then inspired@go.mirror_directory.(If
@go.create_gzipped_tarballdoesn't prove useful in the long run, I can remove it in v2.0.0.)Finally, after digging deeper into process substitution vs. pipes during the implementation of
@go.mirror_directoryfromlib/fileutil, I realized a few things:waithelp.set -o pipefail.Hence,
go-templatenow uses a{curl,fetch,cat,wget} | tarpipe with a[[ ${PIPESTATUS[0]} -ne '0' ]]check. There's a new test case fortarfailure, and the 'fail to download ...' test cases required a little tweaking to ensure they properly cover the cases where${download_cmd[@]}fails.(Yeah, really shoulda been separate PRs.)