lib/portability: Add @go.native_file_path_or_url #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbland
force-pushed
the
native-path-#186-#187
branch
from
1e84be2 to
340c031
Compare
This fixes test breakages on Git for Windows due to the fact that `./go get` now uses `@go.native_file_path_or_url` instead of its own heuristic, which results in some file paths and URLs from the tests getting translated that weren't before.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187. Part of #186. Replaces
git_for_windows_native_pathand updates the interface to print to a result variable rather than standard output, avoiding a subshell when no conversion takes place.