Create public lib/existence module, fix new --test, update demo-core prompt
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests still pass, as the `return 1` case wasn't reachable given that the call to `@go.prompt_for_yes_or_no` was supplied with a default value.
Previously tests created at the top-level of `_GO_TEST_DIR` would contain the line `load ../environment` when it should've been `load environment`. Also updates a misnamed test case in the same file.
Closes #148. This is the last bit of functionality migrated from https://github.com/mbland/certbot-webroot-setup, providing a standard means of checking for file and command existence and reporting errors.
Thought I'd make the test more hermetic by setting `PATH` explicitly, but forgot that Bash is installed under `/usr/local/bin` on FreeBSD. Hopefully no one will have any actual programs named foo, bar, or baz on their system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148. This is the last bit of functionality migrated from https://github.com/mbland/certbot-webroot-setup, providing a standard means of checking for file and command existence and reporting errors.
Also removes and documents an unreachable failure case in
demo-core prompt, fixes theload environmentline fornew --testfor tests created at the top level of_GO_TEST_DIR, and updates a misnamed test case intests/new.bats.