Remove redundant onCompleted call.

benjaminp · copybara-github · commit 0f6dd594fe66 · 2023-03-16T22:40:25.000-07:00
This stops logspam like this: ``` SEVERE: Exception while executing runnable io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed@79f703ef java.lang.IllegalStateException: call already closed at com.google.common.base.Preconditions.checkState(Preconditions.java:502) at io.grpc.internal.ServerCallImpl.closeInternal(ServerCallImpl.java:216) at io.grpc.internal.ServerCallImpl.close(ServerCallImpl.java:209) at io.grpc.stub.ServerCalls$ServerCallStreamObserverImpl.onCompleted(ServerCalls.java:395) at com.google.devtools.build.lib.remote.ByteStreamUploaderTest$2$1.onCompleted(ByteStreamUploaderTest.java:236) at io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onHalfClose(ServerCalls.java:273) at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:352) at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:866) at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) ``` Closes bazelbuild#17792. PiperOrigin-RevId: 517321034 Change-Id: Ia4688e7d52c4d2bb5dc8a6f418b86bebddc70b0a
diff --git a/src/test/java/com/google/devtools/build/lib/remote/ByteStreamUploaderTest.java b/src/test/java/com/google/devtools/build/lib/remote/ByteStreamUploaderTest.java
@@ -233,7 +233,6 @@ public void onError(Throwable throwable) {
 
               @Override
               public void onCompleted() {
-                streamObserver.onCompleted();
               }
             };
           }

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,6 @@ public void onError(Throwable throwable) {`
`233`	`233`
`234`	`234`	`@Override`
`235`	`235`	`public void onCompleted() {`
`236`		`- streamObserver.onCompleted();`
`237`	`236`	`}`
`238`	`237`	`};`
`239`	`238`	`}`