Fix overlay rendering issues that lead to crashing when other overlays are present#1003
Merged
maximegmd merged 4 commits intomaximegmd:masterfrom Feb 18, 2025
Merged
Fix overlay rendering issues that lead to crashing when other overlays are present#1003maximegmd merged 4 commits intomaximegmd:masterfrom
maximegmd merged 4 commits intomaximegmd:masterfrom
Conversation
Handle WM_WINDOWPOSCHANGED correctly for SWP_NOMOVE and SWP_NOSIZE cases
…rsor as necessary
…dual frame contexts instead of sharing frame context 0's allocator for all command lists
Owner
|
Thank you very much for the contribution. I also believe there was a discussion regarding our hooking methodology not handling the SL proxy correctly but did not investigate more. |
maximegmd
approved these changes
Feb 18, 2025
Collaborator
|
Seems good to me, but dont think this really resolves any fencing issues we currently have and I am trying to fix. Or does it? Would be suprised considering issues I found, including leaking SRV heap and such... But should be an improvement I believe still for now. I am rewritting whole hook, had this fixed there among other things, no need necessarily I suppose to do anything on your part with this, just for a note. This is definitely not everything we do wrong atm unfortunately. |
WSSDude
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been getting several reports from Special K users of crashes when using this mod, and finally had some time to investigate.
Primary issues found: