Repository navigation
Minor fixes - #1
Merged
Merged
Conversation
- fix the example output (keys in first-occurrence order, no simple bracket padding, aligned columns) - enable_table_format no longer requires identical keys; describe the merged columns and the fallback behavior - clarify max_table_row_complexity and min_compact_array_row_items - fix the nested_bracket_padding examples - list the comma_placement and number_alignment values - note which FracturedJson options are unsupported, that the default number alignment differs, and that min_table_rows and table_similarity_threshold were removed
maxbachmann
reviewed
Sep 25, 2026
|
|
||
| Compared with the reference FracturedJson implementation, simdjson does not support the options related to comments, blank-line preservation, trailing commas, line-ending style, tab indentation, line prefixes, property-name padding in expanded objects (`MaxPropNamePadding`, `ColonBeforePropNamePadding`), or the `Decimal` and `Normalize` number alignments. | ||
|
|
||
| The `min_table_rows` and `table_similarity_threshold` options found in earlier versions of simdjson have been removed. |
Owner
There was a problem hiding this comment.
Should this mention the removal of max_inline_length and max_items_per_line from simdjson@237e634?
The rest looks good to me.
Author
There was a problem hiding this comment.
Nah I thought about it some more and I don't think it matters enough.
Author
There was a problem hiding this comment.
I don't want to pollute the documentation.
Author
|
@maxbachmann I invite you to merge this. This will be the final step before a major release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation fixes on top of simdjson#2879: corrected example output, updated option descriptions (table keys, row complexity, compact row items, bracket padding examples, comma placement / number alignment values), and noted unsupported FracturedJson options and removed simdjson options.