VideoManager: Fix Recording Name #12999
Conversation
HTRamsey
force-pushed
the
dev-videomanager-recording
branch
2 times, most recently
from
4abddd7 to
0b809ba
Compare
|
Can we get this merged for v5.0 ? |
|
Yup it will be. Just need to figure out if any other changes need to be made for the Android storage permissions stuff |
|
Can I merge this? I want to cut a new RC with it in |
| <uses-permission android:name="android.permission.WAKE_LOCK" /> | ||
| <!-- Needed for read/write to GenericDataLocation of AppSettings --> | ||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | ||
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" /> |
There was a problem hiding this comment.
4.4 stable has:
<uses-permission android:name="android.permission.WRITE_INTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
Any reason to not duplicate all of that since it worked?
There was a problem hiding this comment.
Not exactly sure about write internal but must have been there for some reason :)
There was a problem hiding this comment.
Most of these permissions are auto-generated. Need to double check which ones already get added automatically
There was a problem hiding this comment.
For reference, these are what get added by CMake automatically:
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.BLUETOOTH" />
<uses-permission android:name="android.permission.BLUETOOTH_ADMIN" android:maxSdkVersion="30" />
<uses-permission android:name="android.permission.BLUETOOTH_ADVERTISE" android:minSdkVersion="31" />
<uses-permission android:name="android.permission.BLUETOOTH_CONNECT" android:minSdkVersion="31" />
<uses-permission android:name="android.permission.BLUETOOTH_SCAN" android:minSdkVersion="31" android:usesPermissionFlags="neverForLocation" />
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" />
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
so yeah I need to add Internal Storage
There was a problem hiding this comment.
Nevermind Read/Write Internal isn't a valid permission
HTRamsey
force-pushed
the
dev-videomanager-recording
branch
from
0b809ba to
0a91baa
Compare
HTRamsey
force-pushed
the
dev-videomanager-recording
branch
from
0a91baa to
ff017d2
Compare
3 participants
Fixes #12989
Need to look into Android Permissions & change how multiple stream recordings are named too