Terrain: Fix TerrainQuery crash #12960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a use-after-free crash caused by improper raw pointer usage in TerrainQuery. Key changes: - Replace raw TerrainAtCoordinateQuery pointers with QPointer to automatically track object lifetime. - Remove manual destroyed signal handling and related cleanup code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terrain: Fix TerrainQuery crash
Description
This fixes a use-after-free crash caused by improper raw pointer usage in TerrainQuery.
Key changes:
In addition to this, some no-op logic has been removed.
Test Steps
Connect a real APM vehicle with a mission of around 300 waypoints. The application will often crash after loading the mission and drawing the plan.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.