Plan: Fix old polyline vertices persisting after KML import #12891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yeah the _beginResetIfNotActive/_endResetIfNotActive functions don't make sense to me, because _beginResetIfNotActive sets active to true then _endResetIfNotActive doesn't work because active is then true |
mrschick
force-pushed
the
fix/polyline-vertex-persistence
branch
from
f9b95da to
a010a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12852. Stumbled upon this way of solving it by trying to apply the
beginReset()andendReset()functions also used inQGCMapPolylineVisuals.qml, where they worked correctly to prevent old vertices from persisting (confirmed by trying to comment them out).qgroundcontrol/src/FlightMap/MapItems/QGCMapPolylineVisuals.qml
Lines 64 to 72 in 8016574
Test Steps
The repro case in #12852 won't work anymore, related UI manipulation is not broken by the fix.
Checklist:
Related Issue
Will fix #12852.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.