CI: Add lupdate workflow #12865
Merged
CI: Add lupdate workflow #12865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@DonLakeFlyer is this what you had in mind for the automated lupdate? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new GitHub Actions workflow to automatically update Qt translation files on a weekly schedule and via manual dispatch.
- Schedules a cron job (weekly) and manual trigger
- Installs Qt, runs
lupdateand a Python script to regenerate translation JSON - Commits changes and opens a pull request with updated
.tsand.jsonfiles
Comments suppressed due to low confidence (1)
.github/workflows/lupdate.yml:28
- The action sets the Qt install path in
QT_ROOT(notQT_ROOT_DIR). Update this to${{ env.QT_ROOT }}/bin/lupdateor verify the correct env var from the install-qt-action docs.
${{ env.QT_ROOT_DIR }}/bin/lupdate ../src -ts qgc.ts -no-obsolete
| @@ -0,0 +1,50 @@ | |||
| name: Update Translations | |||
|
|
|||
There was a problem hiding this comment.
[nitpick] Consider adding a concurrency policy at the workflow root to prevent overlapping runs from generating duplicate PRs, e.g.:
concurrency:
group: 'lupdate'
cancel-in-progress: true
Suggested change
| concurrency: | |
| group: 'lupdate' | |
| cancel-in-progress: true |
HTRamsey
force-pushed
the
dev-ci-lupdate
branch
2 times, most recently
from
543d825 to
8292605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run lupdate weekly