Fix rtcm example #748
Merged
Fix rtcm example #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Was tested on real hardware running newest version of PX4, and using real rtcm data. Managed to get RKT Fix. But without this fix I got no errors, but also no RTK fix nor float. |
julianoes
reviewed
Jan 30, 2025
Collaborator
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
Amazing, thanks! Small nitpick below.
Yes, of course 😆 Co-authored-by: Julian Oes <[email protected]>
julianoes
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the example to use base64 encoded string RTCM data, which is expected by MAVSDK 3.0.0
Also removes old RTK example script from MAVSDK 1.x