core: flush after each Log* line (take 2) #2631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-flush-2
branch
2 times, most recently
from
5d4ecce to
3f7c28a
Compare
julianoes
force-pushed
the
pr-segfault-fixes
branch
from
5a3e311 to
3867fb5
Compare
julianoes
force-pushed
the
pr-segfault-fixes
branch
2 times, most recently
from
0dae05e to
f5385dd
Compare
While debugging debug output in MAVSDK-Python I realized that error messages like "Invalid connection" just never appear which is very confusing. I have also seen reports in the past where MAVSDK logs wouldn't show up or show up very late in journalctl (if an application is started via systemd). Again, very confusing. Given we don't print a lot of stuff, and flushing after each line unlikely has real performance implications, I suggest to use std::endl which includes std::flush instead of only printing a newline.
|
This was referenced Aug 1, 2025
julianoes
added a commit
to mavlink/MAVSDK-Python
that referenced
this pull request
Sep 16, 2025
This should now work properly thanks to this fix: mavlink/MAVSDK#2631
julianoes
added a commit
to mavlink/MAVSDK-Python
that referenced
this pull request
Sep 16, 2025
This should now work properly thanks to this fix: mavlink/MAVSDK#2631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging debug output in MAVSDK-Python I realized that error messages like "Invalid connection" just never appear which is very confusing.
I have also seen reports in the past where MAVSDK logs wouldn't show up or show up very late in journalctl (if an application is started via systemd). Again, very confusing.
Given we don't print a lot of stuff, and flushing after each line unlikely has real performance implications, I suggest to use std::endl which includes std::flush instead of only printing a newline.
This replaces #2626. It's currently on top of #2630 for CI testing.