[apache#1823] Align DestinationView and DestinationViewMBean (apache#1824)

mattrpav · web-flow · commit 5658dc7aadf8 · 2026-03-26T10:30:39.000-05:00
diff --git a/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java b/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java
@@ -136,6 +136,12 @@ public long getStoreMessageSize() {
         return messageStore != null ? messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;
     }
 
+    @Override
+    public long getMessagesCachedCount() {
+        return destination.getDestinationStatistics().getMessagesCached().getCount();
+    }
+
+    @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. This method name is inconsistent
     public long getMessagesCached() {
         return destination.getDestinationStatistics().getMessagesCached().getCount();
     }
@@ -437,10 +443,12 @@ public int getMaxProducersToAudit() {
         return destination.getMaxProducersToAudit();
     }
 
+    @Override
     public boolean isEnableAudit() {
         return destination.isEnableAudit();
     }
 
+    @Override
     public void setEnableAudit(boolean enableAudit) {
         destination.setEnableAudit(enableAudit);
     }
diff --git a/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java b/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationViewMBean.java
@@ -131,6 +131,13 @@ public interface DestinationViewMBean {
     @MBeanInfo("Number of producers attached to this destination")
     long getProducerCount();
 
+
+    /**
+     * @return the number of messages cached
+     */
+    @MBeanInfo("Number of messages cached")
+    public long getMessagesCachedCount();
+
     /**
      * Returns the number of messages in this destination which are yet to be
      * consumed
@@ -263,6 +270,19 @@ public String sendTextMessageWithProperties(@MBeanInfo("properties") String prop
     @MBeanInfo("Memory used by undelivered messages in bytes")
     long getMemoryUsageByteCount();
 
+    /**
+     * @return the EnableAudit setting for duplicate message checking
+     */
+    @MBeanInfo("Audit is enabled for duplicate message checking")
+    boolean isEnableAudit();
+
+    /**
+     * set the flag to enable or disable audit for duplicate message checking
+     * @param enableAudit
+     * enable/disable audit on the destination
+     */
+    void setEnableAudit(boolean enableAudit);
+
     /**
      * @return the amount of memory allocated to this destination
      */

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,12 @@ public long getStoreMessageSize() {`
`136`	`136`	`return messageStore != null ? messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;`
`137`	`137`	`}`
`138`	`138`
	`139`	`+ @Override`
	`140`	`+ public long getMessagesCachedCount() {`
	`141`	`+ return destination.getDestinationStatistics().getMessagesCached().getCount();`
	`142`	`+ }`
	`143`	`+`
	`144`	`+ @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. This method name is inconsistent`
`139`	`145`	`public long getMessagesCached() {`
`140`	`146`	`return destination.getDestinationStatistics().getMessagesCached().getCount();`
`141`	`147`	`}`
`@@ -437,10 +443,12 @@ public int getMaxProducersToAudit() {`
`437`	`443`	`return destination.getMaxProducersToAudit();`
`438`	`444`	`}`
`439`	`445`
	`446`	`+ @Override`
`440`	`447`	`public boolean isEnableAudit() {`
`441`	`448`	`return destination.isEnableAudit();`
`442`	`449`	`}`
`443`	`450`
	`451`	`+ @Override`
`444`	`452`	`public void setEnableAudit(boolean enableAudit) {`
`445`	`453`	`destination.setEnableAudit(enableAudit);`
`446`	`454`	`}`