Repository navigation
Commit 76a34d3
authored
fix(seaweedfs): bump the COSI driver to v0.4.0 for the lost-grant fix (cozystack#5284)
## What this PR does
This PR bumps seaweedfs COSI driver to v0.4.0, because v0.3.1 can lose a
grant for good: BucketAccess reports `accessGranted` and its Secret is
written, but S3 gateways keep rejecting the key with
`InvalidAccessKeyId`. Fixes cozystack#4912.
Driver v0.3.1 grants access by rewriting legacy
`/etc/iam/identity.json`, and every S3 gateway migrates this file to
per-identity files and renames it away on each change, so grant written
during migration is dropped. v0.4.0 also writes
`/etc/iam/identities/<user>.json` on grant
(seaweedfs/seaweedfs-cosi-driver#15). First version of this PR built the
driver from that upstream commit, now upstream released v0.4.0 so it's
just a tag bump.
Rest of v0.4.0 doesn't reach the platform:
- `readwrite-governance-bypass` access policy
(seaweedfs/seaweedfs-cosi-driver#16) is opt-in, none of our
BucketAccessClasses use it.
- Bucket deletion is refused while objects hold an active lock
(seaweedfs/seaweedfs-cosi-driver#18), only for object-lock buckets. All
`-lock` BucketClasses are `Retain`, and sidecar calls DriverDeleteBucket
only for `Delete`.
- Filer errors (seaweedfs/seaweedfs-cosi-driver#20) are now matched by
exact not-found message, I checked it against seaweedfs 4.45 filer and
formats match. One behavior change: bucket deletion doesn't ignore
errors of the recursive delete anymore, so sidecar retries instead of
reporting success.
How I tested (seaweedfs 4.45, two S3 gateways): Bucket with one user,
then three more users added in one change, after a minute ListObjects
with each user key, rejected key retried once more after 30s. Five runs
for each driver, the fixed one is a build of `5efd120`, the commit
v0.4.0 takes the grant fix from:
| driver | keys rejected for good |
| --- | --- |
| v0.3.1 | 5 of 20 (4 runs out of 5 lost at least one) |
| `5efd120` | 0 of 20 |
Same failure broke v1.7.1-rc.1 e2e, RabbitMQ backup round-trip got `403
InvalidAccessKeyId` for freshly granted key:
https://github.com/cozystack/cozystack/actions/runs/42980741995
Keys already lost on running clusters stay broken after upgrade.
Workaround from cozystack#4912 still works: remove user from Bucket, wait until
its BucketAccess is gone, add it back.
### Screenshots
Not a UI change.
### Downstream repositories
- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:
### Release note
```release-note
fix(seaweedfs): bucket users granted together could get S3 keys that never work (403 InvalidAccessKeyId). COSI driver is bumped to v0.4.0, which writes each grant to per-identity IAM file.
```
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **Updates**
* Updated the SeaweedFS COSI driver to version `v0.4.0`.
* The updated driver writes IAM files per identity, helping preserve
grants when identity files are updated.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->3 files changed
Lines changed: 8 additions & 5 deletions
File tree
- packages
- extra/seaweedfs/images
- system/seaweedfs
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
307 | 310 | | |
308 | 311 | | |
309 | 312 | | |
| |||
0 commit comments