Repository navigation
Commit 06817c1
committed
chore(tests): remove the two dead monitoring OIDC bats suites
`hack/e2e-apps/monitoring-oidc-system.bats` and
`hack/e2e-apps/monitoring-oidc-customconfig.bats` are executed by
nothing. `BATS_UNIT_FILES` is built from
`$(filter-out hack/e2e-%.bats,$(wildcard hack/*.bats))`, which is neither
recursive nor inclusive of e2e names; `hack/select-e2e.sh` matches
`hack/[^/]+\.bats$` only; and `packages/core/testing/Makefile` names
three bats files one by one, none of them these.
`hack/e2e-chainsaw/README.md` records why: that directory replaced the
per-app BATS suite, and these two were left behind when the old one
stopped being wired up.
Both read as live coverage — their headers say "What is exercised here on
a live cluster" — so anyone grepping for monitoring OIDC coverage finds
them and concludes it exists. It does not: `hack/e2e-chainsaw/` has no
monitoring OIDC equivalent, and no run can check what these two assert.
They also each call `skip`, which `hack/cozytest.sh` does not implement
(cozystack#3827), so the branch written to tolerate absent Keycloak CRDs is the
one that would break on them, at exit 127.
Deleting them takes the decision cozystack#3638 and cozystack#3786 asked for. The Chainsaw
port stays wanted and is tracked in cozystack#4051.
The four comments that asserted what the directory currently holds are
reworded to speak of a suite placed there instead. The `hack/e2e-apps/*`
arm in `select-e2e.sh`, the capture gate in `cozytest.sh` and the
recursive audit in `bats-no-exit-trap.bats` stay exactly as they are,
deliberately: a suite landing there later must still be selected,
captured and audited.
Closes cozystack#3638
Closes cozystack#3786
Signed-off-by: Mattia Eleuteri <[email protected]>
Assisted-By: Claude <[email protected]>1 parent 356a377 commit 06817c1
6 files changed
Lines changed: 12 additions & 443 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
571 | 571 | | |
572 | 572 | | |
573 | 573 | | |
574 | | - | |
575 | | - | |
576 | | - | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
179 | | - | |
180 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
164 | | - | |
| 163 | + | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| |||
This file was deleted.
0 commit comments