test: cover the nine lines #3575 left uncovered#3577
Merged
Conversation
#3575 merged with codecov/patch red. Measured against the merge commit, nine added lines had no test; all nine are reachable behaviour, not scaffolding: - Undo reporting a removal that removed nothing, and one that threw. Both paths existed precisely so a failed undo stops looking like a successful one, and neither was exercised. - The create path's non-blocking failure message. Only a blocks edge can fail the cycle guard, so the other branch names a plain failure — the existing test covered the blocks branch alone. - The empty card's "create new linked task" row, which is that screen's only worded entry point to the flow. - The link picker reached through manage mode's overflow, where the header slot is taken by Done. - The icon-only link action in a locale whose label will not fit, asserting it still opens the picker: the action drops its word, not its function. - subtitleEmphasis on DesignSystemListItem's subtitleSpans path, so the two subtitle paths cannot disagree about which parameter wins. Verified by intersecting the merge commit's added lines with local lcov: nine before, zero after.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughChangesThe pull request adds widget coverage for Design system validation
Linked-task interaction validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/features/tasks/ui/linked_tasks/linked_tasks_widget_actions_test.dart`:
- Around line 743-753: Remove the redundant expect assertion for the
blocking-cycle message from the test, keeping the existing identical assertion
later in the same test body and preserving the surrounding cycle-handling
coverage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1d10c650-e88c-42e4-8394-35793aadb1e2
📒 Files selected for processing (3)
test/features/design_system/components/lists/design_system_list_item_test.darttest/features/tasks/ui/linked_tasks/link_task_modal_test.darttest/features/tasks/ui/linked_tasks/linked_tasks_widget_actions_test.dart
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
==========================================
+ Coverage 91.06% 99.14% +8.08%
==========================================
Files 1783 1783
Lines 130609 130627 +18
==========================================
+ Hits 118934 129515 +10581
+ Misses 11675 1112 -10563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3575 merged with
codecov/patchred. Measuring the merge commit's addedlines against local lcov found nine with no test. All nine are reachable
behaviour rather than scaffolding, and several are the error paths that PR
added specifically so failures stop being silent — so they are worth covering
rather than waiving.
link_created_feedback.dart74, 76, 83, 85removeTypedLinkreturns a row count and throws nothing when it matches no row, which is exactly why these branches exist.linked_tasks_widget.dart573blocksedge can fail the cycle guard; the existing test covered that branch alone, so the plain-failure branch never ran.linked_tasks_widget.dart120linked_tasks_widget.dart423linked_tasks_widget.dart386design_system_list_item.dart346subtitleEmphasison thesubtitleSpanspath, so the two subtitle paths cannot disagree about which parameter wins.Six tests, no production changes.
pumpWidgetinlinked_tasks_widget_actions_test.dartgainedwidthandlocale, matching the helper inlinked_tasks_widget_test.dart— viaAlign,because the bench hands its child tight constraints and a width set any other
way is silently ignored.
Verification
Added lines of
fa842e6bcintersected withcoverage/lcov.info: nineuncovered before, zero after.
fvm flutter analyzeclean acrosslib/andtest/features; 218 tests green in the touched directories.Summary by CodeRabbit