optimize empty-line handling for li and blockquote content#171
Merged
chrispy-snps merged 1 commit intomatthewwithanm:developfrom Jan 19, 2025
Conversation
AlexVonB
approved these changes
Jan 2, 2025
Signed-off-by: chrispy <[email protected]>
4fd03de to
17c3678
Compare
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
…ize-li-blockquote-empty-lines optimize empty-line handling for li and blockquote content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170.
The
convert_li()andconvert_blockquote()functions are updated to use "substitution functions" to compute how each line should be modified. Inside the functions, different actions are taken for content lines versus empty lines.For example (spaces replaced with
·in output):Unit tests are updated to reflect the changes. In addition, manual tests were performed by using Pandoc to convert the Markdown back to HTML to verify correctness.