Bug-for bug compatibility with libolm's PkEncryption support#171
Merged
Bug-for bug compatibility with libolm's PkEncryption support#171
Conversation
poljar
force-pushed
the
poljar/pk-dekurcina
branch
2 times, most recently
from
6f97915 to
c231c72
Compare
poljar
changed the title
Collaborator
Author
|
Trying to get our codecov thing going. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 34 34
Lines 1907 1907
=======================================
Hits 1723 1723
Misses 184 184 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/pk-dekurcina
branch
from
d50e302 to
0057971
Compare
MatMaul
reviewed
Sep 6, 2024
poljar
force-pushed
the
poljar/pk-dekurcina
branch
from
0057971 to
a6a0ed1
Compare
dkasak
approved these changes
Sep 10, 2024
Member
dkasak
left a comment
dkasak
left a comment
There was a problem hiding this comment.
Looks good overall, though I reworded a bunch of stuff as usual. Clicking approved so it doesn't require another roundtrip.
poljar
force-pushed
the
poljar/pk-dekurcina
branch
from
d10d1f4 to
805e657
Compare
This patch introduces support for the libolm PkEncryption/PkDecryption concepts, ensuring bug-for-bug compatibility with libolm. Notably, the libolm implementation has a known flaw that leaves ciphertext unauthenticated, as documented in the Matrix spec [1]. To address this, the feature is gated behind a feature flag to better inform users of this issue. [1]: https://spec.matrix.org/v1.11/client-server-api/#backup-algorithm-mmegolm_backupv1curve25519-aes-sha2 Changelog: Add support for the libolm PkEncryption feature. This allows Matrix clients to implement the [m.megolm_backup.v1.curve25519-aes-sha2](https://spec.matrix.org/v1.11/client-server-api/#backup-algorithm-mmegolm_backupv1curve25519-aes-sha2) room key backup algorithm. Please note that this algorithm contains a critical flaw and should only be used for compatibility reasons.
poljar
force-pushed
the
poljar/pk-dekurcina
branch
from
805e657 to
484317b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review commit-by-commit is advised, there are a couple of unrelated commits here to make the CI happy.
The meat of the PR is the libolm's PKEncryption support, for more info please take a look at the commit message which adds this functionality. Please note that the commit message assumes that we're going to merge #165.