Apply const keyword to various methods#167
Merged
poljar merged 2 commits intomatrix-org:mainfrom Aug 8, 2024
Merged
Conversation
… clippy check Also enables `clippy::missing_const_for_fn` as a warning
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 90.55% 90.55%
=======================================
Files 34 34
Lines 1905 1906 +1
=======================================
+ Hits 1725 1726 +1
Misses 180 180 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
(just commeting to ack that I have seen the clippy ci failing. Deal Ing with that when at my pc :)) |
Signed-off-by: MTRNord <[email protected]>
poljar
approved these changes
Aug 8, 2024
Collaborator
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Not sure how terribly useful this is but it shouldn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the feedback given by the clippy
missing_const_for_fnlint, which is still in nursery.In a very non-scientific comparison, the
olm-message-decodingafl fuzzer runs with ~0.5k to ~1k more executions per second on my PC.I did not verify if any bindings rely on these to be not
const. However, the test suite returned that everything is ok.Signed-Off-By: MTRNord [email protected]