Skip to content

MSC4444: Malicious PDUs#4444

Closed
velikopter wants to merge 3 commits intomatrix-org:mainfrom
velikopter:evil-pdus
Closed

MSC4444: Malicious PDUs#4444
velikopter wants to merge 3 commits intomatrix-org:mainfrom
velikopter:evil-pdus

Conversation

@velikopter
Copy link
Copy Markdown
Contributor

@velikopter velikopter commented Apr 1, 2026 •
edited
Loading

Rendered

Implementations:

  • Client:
    • Receiving:
    • Sending:
  • Server:

Signed-off-by: Helix K [email protected]

thetayloredman
thetayloredman approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@thetayloredman thetayloredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. We should fast-track this into an interim spec release.

thetayloredman
thetayloredman reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@thetayloredman thetayloredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one.

Comment thread proposals/4444-malicious-pdus.md
@thetayloredman
Copy link
Copy Markdown

thetayloredman commented Apr 1, 2026 •
edited
Loading

Client implementation in Ruma: thetayloredman/ruma@9502ee3

anoadragon453
anoadragon453 approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only glanced at the proposal, but I think it's ready to merge into the spec.

However, before I do so, @velikopter can you just quickly write a comment stating "I promise this MSC isn't malicious!". It's just so I know you're being an upstanding Matrix contributor!

Thanks for your hard work!

@uhoreg uhoreg added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. requires-room-version An idea which will require a bump in room version labels Apr 1, 2026
uhoreg
uhoreg reviewed Apr 1, 2026
View reviewed changes
Comment thread proposals/4444-malicious-pdus.md Outdated
Comment thread proposals/4444-malicious-pdus.md
@velikopter
Copy link
Copy Markdown
Contributor Author

velikopter commented Apr 1, 2026

I promise this MSC isn't malicious!

JadedBlueEyes
JadedBlueEyes reviewed Apr 1, 2026
View reviewed changes
Comment thread proposals/4444-malicious-pdus.md
|---------------------:|:----------------------------------------------|
| `M_SPEAK_NO_EVIL` | `COM.NHJKL.MSC4444.SPEAK_NO_EVIL` |
| `evil` query param | `com.nhjkl.msc4444.evil` |
| Room version: | `com.nhjkl.msc4444.opt2`, based on v3. |
Copy link
Copy Markdown

@JadedBlueEyes JadedBlueEyes Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think room version 3 might be too new? Can we have this based on v1 to resolve compatiblity issues, thanks

@turt2live turt2live added the unassigned-room-version Remove this label when things get versioned. label Apr 1, 2026
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Apr 2, 2026

April Fools is over, so closing this to keep the various MSC trackers legible :)

@turt2live turt2live closed this Apr 2, 2026
@turt2live turt2live added the rejected A proposal which has been rejected for inclusion in the spec label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uhoreg uhoreg uhoreg left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

+2 more reviewers

@thetayloredman thetayloredman thetayloredman approved these changes

@JadedBlueEyes JadedBlueEyes JadedBlueEyes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal rejected A proposal which has been rejected for inclusion in the spec requires-room-version An idea which will require a bump in room version unassigned-room-version Remove this label when things get versioned.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@velikopter @thetayloredman @turt2live @uhoreg @anoadragon453 @JadedBlueEyes