MSC4376: Remove /v1/send_join and /v1/send_leave#4376
MSC4376: Remove /v1/send_join and /v1/send_leave#4376turt2live merged 9 commits intomatrix-org:mainfrom
Conversation
d6ce82f to
d195106
Compare
Signed-off-by: Johannes Marbach <[email protected]>
d195106 to
2964b13
Compare
There was a problem hiding this comment.
Implementation requirements waived given time, security context, and implementation of fallback.
There was a problem hiding this comment.
Seems the implementation requirements have now been effectively satisfied, as the MSC goes through the major server implementations and demonstrates that they both: 1) implement /v2/ endpoints server-side and 2) prefer /v2 when making requests.
turt2live
left a comment
There was a problem hiding this comment.
Thanks for working on this, and sorry for forgetting it 😅
I've done a pass of the implementations and it looks like all the same arguments for send_join are present for send_leave too. This review looks complicated, but it's really just adding the text to also remove send_leave in the same MSC.
In practice, despite this MSC, implementations are likely to continue supporting the endpoints for quite a while anyway because they'll want to support older spec versions (typically). This still removes maintenance burden on the spec though, which is good.
|
MSCs proposed for Final Comment Period (FCP) should meet the requirements outlined in the checklist prior to being accepted into the spec. This checklist is a bit long, but aims to reduce the number of follow-on MSCs after a feature lands. SCT members: please check off things you check for, and raise a concern against FCP if the checklist is incomplete. If an item doesn't apply, prefer to check it rather than remove it. Unchecking items is encouraged where applicable. MSC authors: feel free to ask in a thread on your MSC or in the#matrix-spec:matrix.org room for clarification of any of these points.
|
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
|
This looks ready for broader review @mscbot fcp merge |
|
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
Co-authored-by: Kierre Sametti <[email protected]>
There was a problem hiding this comment.
Seems the implementation requirements have now been effectively satisfied, as the MSC goes through the major server implementations and demonstrates that they both: 1) implement /v2/ endpoints server-side and 2) prefer /v2 when making requests.
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
|
Spec PR: matrix-org/matrix-spec#2319 |
now merged |
Rendered
Fixes: matrix-org/matrix-spec#1519
SCT Stuff:
MSC checklist
FCP tickyboxes