Skip to content

MSC4376: Remove /v1/send_join and /v1/send_leave#4376

Merged
turt2live merged 9 commits intomatrix-org:mainfrom
Johennes:johannes/remove-send-join-v1
Feb 23, 2026
Merged

MSC4376: Remove /v1/send_join and /v1/send_leave#4376
turt2live merged 9 commits intomatrix-org:mainfrom
Johennes:johannes/remove-send-join-v1

Conversation

@Johennes
Copy link
Copy Markdown
Contributor

@Johennes Johennes commented Oct 31, 2025

@Johennes Johennes changed the title MSCXXXX: Remove /v1/send_join MSC4376: Remove /v1/send_join Oct 31, 2025
@Johennes Johennes force-pushed the johannes/remove-send-join-v1 branch from d6ce82f to d195106 Compare October 31, 2025 11:14
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes force-pushed the johannes/remove-send-join-v1 branch from d195106 to 2964b13 Compare October 31, 2025 11:15
@Johennes Johennes marked this pull request as ready for review October 31, 2025 11:16
@turt2live turt2live added proposal A matrix spec change proposal s2s Server-to-Server API (federation) kind:maintenance MSC which clarifies/updates existing spec hacktoberfest-accepted needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Oct 31, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements waived given time, security context, and implementation of fallback.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the implementation requirements have now been effectively satisfied, as the MSC goes through the major server implementations and demonstrates that they both: 1) implement /v2/ endpoints server-side and 2) prefer /v2 when making requests.

@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Oct 31, 2025
@github-project-automation github-project-automation bot moved this to Tracking for review in Spec Core Team Workflow Jan 16, 2026
@turt2live turt2live moved this from Tracking for review to Proposed for FCP readiness in Spec Core Team Workflow Jan 16, 2026
@turt2live turt2live added the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Jan 16, 2026
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, and sorry for forgetting it 😅

I've done a pass of the implementations and it looks like all the same arguments for send_join are present for send_leave too. This review looks complicated, but it's really just adding the text to also remove send_leave in the same MSC.

In practice, despite this MSC, implementations are likely to continue supporting the endpoints for quite a while anyway because they'll want to support older spec versions (typically). This still removes maintenance burden on the spec though, which is good.

@turt2live
Copy link
Copy Markdown
Member

turt2live commented Jan 20, 2026

MSCs proposed for Final Comment Period (FCP) should meet the requirements outlined in the checklist prior to being accepted into the spec. This checklist is a bit long, but aims to reduce the number of follow-on MSCs after a feature lands.

SCT members: please check off things you check for, and raise a concern against FCP if the checklist is incomplete. If an item doesn't apply, prefer to check it rather than remove it. Unchecking items is encouraged where applicable.

MSC authors: feel free to ask in a thread on your MSC or in the#matrix-spec:matrix.org room for clarification of any of these points.

  • Are appropriate implementation(s) specified in the MSC’s PR description?
  • Are all MSCs that this MSC depends on already accepted?
  • For each new endpoint that is introduced:
    • Have authentication requirements been specified?
    • Have rate-limiting requirements been specified?
    • Have guest access requirements been specified?
    • Are error responses specified?
      • Does each error case have a specified errcode (e.g. M_FORBIDDEN) and HTTP status code?
        • If a new errcode is introduced, is it clear that it is new?
  • Will the MSC require a new room version, and if so, has that been made clear?
    • Is the reason for a new room version clearly stated? For example, modifying the set of redacted fields changes how event IDs are calculated, thus requiring a new room version.
  • Are backwards-compatibility concerns appropriately addressed?
  • Are the endpoint conventions honoured?
    • Do HTTP endpoints use_underscores_like_this?
    • Will the endpoint return unbounded data? If so, has pagination been considered?
    • If the endpoint utilises pagination, is it consistent with the appendices?
  • An introduction exists and clearly outlines the problem being solved. Ideally, the first paragraph should be understandable by a non-technical audience.
  • All outstanding threads are resolved
    • All feedback is incorporated into the proposal text itself, either as a fix or noted as an alternative
  • While the exact sections do not need to be present, the details implied by the proposal template are covered. Namely:
    • Introduction
    • Proposal text
    • Potential issues
    • Alternatives
    • Dependencies
  • Stable identifiers are used throughout the proposal, except for the unstable prefix section
    • Unstable prefixes consider the awkward accepted-but-not-merged state
    • Chosen unstable prefixes do not pollute any global namespace (use “org.matrix.mscXXXX”, not “org.matrix”).
  • Changes have applicable Sign Off from all authors/editors/contributors
  • There is a dedicated "Security Considerations" section which detail any possible attacks/vulnerabilities this proposal may introduce, even if this is "None.". See RFC3552 for things to think about, but in particular pay attention to the OWASP Top Ten.

Johennes and others added 7 commits January 20, 2026 18:43
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
@Johennes Johennes changed the title MSC4376: Remove /v1/send_join MSC4376: Remove /v1/send_join and /v1/send_leave Jan 20, 2026
@turt2live
Copy link
Copy Markdown
Member

This looks ready for broader review

@mscbot fcp merge

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Jan 20, 2026

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jan 20, 2026
@turt2live turt2live moved this from Proposed for FCP readiness to Ready for FCP ticks in Spec Core Team Workflow Jan 20, 2026
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the implementation requirements have now been effectively satisfied, as the MSC goes through the major server implementations and demonstrates that they both: 1) implement /v2/ endpoints server-side and 2) prefer /v2 when making requests.

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 17, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Feb 17, 2026
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Workflow Feb 18, 2026
@turt2live turt2live removed the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Feb 18, 2026
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 22, 2026

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Feb 22, 2026
@velikopter
Copy link
Copy Markdown
Contributor

Spec PR: matrix-org/matrix-spec#2319

@turt2live turt2live merged commit 9be2915 into matrix-org:main Feb 23, 2026
1 check passed
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Feb 23, 2026
@turt2live turt2live moved this from In FCP to Requires spec PR review in Spec Core Team Workflow Feb 23, 2026
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Feb 24, 2026

Spec PR: matrix-org/matrix-spec#2319

now merged

@richvdh richvdh moved this from Requires spec PR review to Merged/Done in Spec Core Team Workflow Feb 24, 2026
@richvdh richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal s2s Server-to-Server API (federation)

Projects

Status: Merged/Done

Development

Successfully merging this pull request may close these issues.

remove v1 send_join

7 participants