MSC4142: Remove unintentional intentional mentions in replies#4142
MSC4142: Remove unintentional intentional mentions in replies#4142
Conversation
Signed-off-by: Tulir Asokan <[email protected]>
|
Discussion about the issue on the original MSC: #3952 (comment) |
Signed-off-by: Tulir Asokan <[email protected]>
There was a problem hiding this comment.
Implementation requirements:
- Client code for the feature - Implement MSC4142: Remove unintentional intentional mentions in replies matrix-react-sdk#12511
- Actively used by users to demonstrate desired behaviour
There was a problem hiding this comment.
Actively used by users to demonstrate desired behaviour
Not entirely sure what that means 🤔 The PR opening comment has an example of the currently specced behavior being undesired, and I think it's relatively obvious that mentioning the user you're replying to is desired
There was a problem hiding this comment.
Notifications have always been a pretty controversial area to be within. Where some folks consider it a bug, others don't.
That requirement is mostly to say it needs opinion from Product-centered folks.
There was a problem hiding this comment.
The Element product team has approved the change now
There was a problem hiding this comment.
I don't think anyone has complained about the lack of unexpected mentions in the past few months
|
MSCs proposed for Final Comment Period (FCP) should meet the requirements outlined in the checklist prior to being accepted into the spec. This checklist is a bit long, but aims to reduce the number of follow-on MSCs after a feature lands. SCT members: please check off things you check for, and raise a concern against FCP if the checklist is incomplete. If an item doesn't apply, prefer to check it rather than remove it. Unchecking items is encouraged where applicable. Checklist:
|
|
@mscbot fcp merge |
|
Team member @tulir has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
|
Spec PR: matrix-org/matrix-spec#2210 |
|
Merged! 🎉 |
Rendered
Implementations:
This MSC was inspired by an unintentional mention chain in Matrix HQ
SCT stuff:
MSC checklist
FCP tickyboxes