Skip to content

MSC3927: Extensible Events - Audio#3927

Open
turt2live wants to merge 4 commits intomainfrom
travis/msc/extev/audio
Open

MSC3927: Extensible Events - Audio#3927
turt2live wants to merge 4 commits intomainfrom
travis/msc/extev/audio

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented Nov 13, 2022

@turt2live turt2live changed the title Extensible Events - Audio MSC3927: Extensible Events - Audio Nov 13, 2022
@turt2live turt2live added proposal A matrix spec change proposal kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 13, 2022
@turt2live turt2live marked this pull request as ready for review November 13, 2022 00:31
Comment thread proposals/3927-extensible-events-audio.md Outdated
Comment thread proposals/3927-extensible-events-audio.md Outdated
Copy link
Copy Markdown
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a mention of "image" 🙃


what! I used the view feature wrongly again, sorry.

"size": 12345
},
"m.audio_details": { // optional
"duration": 90
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more precision and using milliseconds would be good approach. That especially comfortable if the files are used to combine for notification sounds or other programmatic use cases.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, and milliseconds is also what Element already implements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal

Projects

Status: Tracking for review
Status: Scheduled - v1.10

Development

Successfully merging this pull request may close these issues.

3 participants