MSC2883: [WIP] Matrix-flavoured MLS#2883
Draft
uhoreg wants to merge 4 commits intomatrix-org:old_masterfrom
Draft
MSC2883: [WIP] Matrix-flavoured MLS#2883uhoreg wants to merge 4 commits intomatrix-org:old_masterfrom
uhoreg wants to merge 4 commits intomatrix-org:old_masterfrom
Conversation
uhoreg
changed the title
turt2live
added
the
needs-implementation
uhoreg
commented
Oct 4, 2023
| a `|`, as that is how identity is represented (see the Credentials section | ||
| above).\] If the base epoch is the initial epoch, then the `commit_event` | ||
| property should be set to the event ID of the `m.room.create` event. | ||
| * send to-device messages to all new devices with type `m.room.encrypted` |
Member
Author
There was a problem hiding this comment.
Welcome messages could also be sent to room, rather than as to-device messages. We need to figure out which one is better.
uhoreg
commented
Oct 4, 2023
|
|
||
| ```json | ||
| { | ||
| "algorithm": "m.mls.v1.welcome.[ciphersuite]", |
Member
Author
There was a problem hiding this comment.
Suggested change
| "algorithm": "m.mls.v1.welcome.[ciphersuite]", | |
| "algorithm": "m.dmls.v1.welcome.[ciphersuite]", |
Johennes
reviewed
Jul 26, 2024
|
|
||
| \[TODO: In MLS, a group is identified by a <256-byte string. Matrix does not | ||
| have a limit on the length of room IDs. We should probably set a length limit | ||
| as other identifiers have a length limit. We could also use a hash of the room |
Contributor
There was a problem hiding this comment.
In 1.11 room IDs are now explicitly limited to 255 bytes: https://spec.matrix.org/v1.11/appendices/#room-ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered