MSC2582: Remove mimetype from EncryptedFile object by Sorunome · Pull Request #2582 · matrix-org/matrix-spec-proposals

Sorunome · 2020-05-26T14:08:00Z

Signed-off-by: Sorunome [email protected]

Implementations:

Element Android: Cleanup redundant fields - TO BE MERGED ON JULY 1st element-hq/element-android#3273
Element iOS: Remove Redundant mimetype Fields matrix-ios-sdk#1125
Element Web: Use the mimetype from the info property rather than the EncryptedFile matrix-react-sdk#6591

Link to relevant spec: https://spec.matrix.org/unstable/client-server-api/#extensions-to-mroommessage-msgtypes

Sorunome · 2020-05-26T14:09:35Z

Related PR: #2581

turt2live · 2020-05-26T14:09:56Z

Arbitrarily blocking this on someone commenting on #2581

turt2live · 2020-05-26T15:07:13Z

(per #matrix-spec: this PR is required to remove the attribute - unblocked).

uhoreg · 2020-05-27T18:40:02Z

+
+
+## Potential issues
+Some clients might depend on this?


TODO: check client support

(I will update this list as we determine what changes are needed for clients.)

(in alphabetical order)

fluffychat

gomuks

nheko

nio SDK

weechat-matrix (does not seem to use anything)

mirage

~~Riot~~ Element Android

~~Riot~~ Element iOS

~~Riot~~ Element Web

the decryptFile function only gets passed the file property from the contents. To fix this, we'd need to either pass both the file and info properties, or the entire contents.

rust sdk (does not seem to do any mimetype processing on its own)

Fluffychat doesn't seem to depend on this, either

Element Android dropped this field in element-hq/element-android#3273. Element iOS in matrix-org/matrix-ios-sdk#1125. The open issue for Element Web is element-hq/element-web#17145.

Element no longer uses this field, and uses the mimetype from the info field: matrix-org/matrix-react-sdk#6591 (It will still send the field for now, but that's less important for this MSC)

@tulir do you know what gomuks does? Also, any of your bridges.

My libraries don't support that field at all

OK, so it seems like all clients don't use the undocumented field any more, so I think it this potential issue is no longer an issue.

uhoreg · 2021-08-10T21:46:10Z

+
+## Proposal
+The example in the spec currently lists `mimetype` in the examples for `EncryptedFile` but not in
+the object definition. As that is duplicate information of the `info` block of file events, the


Just to note that the EncryptedFile appears twice in the examples: in the file property (top-level) and it info.thumbnail_file. mimetype is given in both places.

the mimetype in EncryptedFile is undocumented and redundant. see matrix-org/matrix-spec-proposals#2582

uhoreg · 2021-08-11T15:01:32Z

@mscbot fcp merge

mscbot · 2021-08-11T15:01:34Z

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

turt2live

I'm a bit confused as to why this is an MSC, but I guess better safe than sorry.

mscbot · 2021-08-24T16:32:36Z

🔔 This is now entering its final comment period, as per the review above. 🔔

Co-authored-by: Hubert Chathi <[email protected]>

Sorunome · 2021-08-28T08:53:01Z

Just committed the two suggestions 👍

mscbot · 2021-08-29T16:32:46Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

* add proposal * Update proposals/2582-remove-mimetype-from-encrypted-file.md Co-authored-by: Hubert Chathi <[email protected]> * Update proposals/2582-remove-mimetype-from-encrypted-file.md Co-authored-by: Hubert Chathi <[email protected]> Co-authored-by: Hubert Chathi <[email protected]>

MSC: #2582

turt2live · 2021-09-24T21:28:43Z

Spec PR: #3412

…3412) * Remove extraneous mimetype from EncryptedFile examples, per MSC2582 MSC: #2582 * changelog

turt2live · 2021-09-27T16:05:42Z

Merged 🎉

add proposal

01f4b78

Sorunome mentioned this pull request May 26, 2020

Fix EncryptedFile lacking mimetype #2581

Closed

turt2live added blocked Something needs to be done before action can be taken on this PR/issue. proposal A matrix spec change proposal proposal-in-review labels May 26, 2020

turt2live removed the blocked Something needs to be done before action can be taken on this PR/issue. label May 26, 2020

uhoreg reviewed May 26, 2020

View reviewed changes

Comment thread proposals/2582-remove-mimetype-from-encrypted-file.md

turt2live requested review from turt2live and uhoreg and removed request for uhoreg May 27, 2020 14:46

uhoreg reviewed May 27, 2020

View reviewed changes

turt2live removed their request for review November 10, 2020 05:28

turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 8, 2021

deepbluev7 mentioned this pull request Apr 13, 2021

Images sent from Nheko do not show up in Mirage Nheko-Reborn/nheko#549

Closed

turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021

uhoreg reviewed Aug 10, 2021

View reviewed changes

uhoreg mentioned this pull request Aug 10, 2021

Use the mimetype from the info property rather than the EncryptedFile matrix-org/matrix-react-sdk#6591

Merged

uhoreg added a commit to matrix-org/matrix-react-sdk that referenced this pull request Aug 10, 2021

use the mimetype from the info property rather than the EncryptedFile

3b98107

the mimetype in EncryptedFile is undocumented and redundant. see matrix-org/matrix-spec-proposals#2582

turt2live self-requested a review August 11, 2021 13:43

uhoreg removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Aug 11, 2021

mscbot added disposition-merge and removed proposal-in-review labels Aug 11, 2021

turt2live approved these changes Aug 15, 2021

View reviewed changes

ShadowJonathan mentioned this pull request Aug 15, 2021

[Scan Encrypted Content] Include in the parameters sent to the content scanner the mimetype extracted from the content.info. matrix-org/matrix-ios-sdk#1186

Closed

anoadragon453 approved these changes Aug 16, 2021

View reviewed changes

Comment thread proposals/2582-remove-mimetype-from-encrypted-file.md Outdated

richvdh reviewed Aug 24, 2021

View reviewed changes

Comment thread proposals/2582-remove-mimetype-from-encrypted-file.md Outdated

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Aug 24, 2021

Sorunome and others added 2 commits August 28, 2021 10:52

Update proposals/2582-remove-mimetype-from-encrypted-file.md

e0f1b09

Co-authored-by: Hubert Chathi <[email protected]>

Update proposals/2582-remove-mimetype-from-encrypted-file.md

46cfac7

Co-authored-by: Hubert Chathi <[email protected]>

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Aug 29, 2021

turt2live merged commit e895827 into matrix-org:old_master Aug 30, 2021

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Aug 30, 2021

turt2live added a commit that referenced this pull request Sep 24, 2021

Remove extraneous mimetype from EncryptedFile examples, per MSC2582

bcf8315

MSC: #2582

turt2live mentioned this pull request Sep 24, 2021

Remove extraneous mimetype from EncryptedFile examples, per MSC2582 #3412

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 24, 2021

turt2live self-assigned this Sep 24, 2021

turt2live added a commit that referenced this pull request Sep 27, 2021

Remove extraneous mimetype from EncryptedFile examples, per MSC2582 (#…

b7e6104

…3412) * Remove extraneous mimetype from EncryptedFile examples, per MSC2582 MSC: #2582 * changelog

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 27, 2021

uhoreg mentioned this pull request Jul 26, 2020

EncryptedFile examples containing mimetype matrix-org/matrix-spec#569

Closed

Conversation

Sorunome commented May 26, 2020 • edited by uhoreg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sorunome commented May 26, 2020

Uh oh!

turt2live commented May 26, 2020

Uh oh!

turt2live commented May 26, 2020

Uh oh!

Uh oh!

uhoreg May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sorunome May 29, 2020

Choose a reason for hiding this comment

Uh oh!

anoadragon453 Aug 6, 2021

Choose a reason for hiding this comment

Uh oh!

uhoreg Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

uhoreg Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tulir Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

uhoreg Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

uhoreg Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

uhoreg commented Aug 11, 2021

Uh oh!

mscbot commented Aug 11, 2021 • edited by erikjohnston Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

turt2live left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mscbot commented Aug 24, 2021

Uh oh!

Sorunome commented Aug 28, 2021

Uh oh!

mscbot commented Aug 29, 2021

Uh oh!

turt2live commented Sep 24, 2021

Uh oh!

turt2live commented Sep 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Sorunome commented May 26, 2020 •

edited by uhoreg

Loading

uhoreg May 27, 2020 •

edited

Loading

uhoreg Aug 10, 2021 •

edited

Loading

mscbot commented Aug 11, 2021 •

edited by erikjohnston

Loading