MSC2425: Remove Authentication on /submitToken Identity Service API#2425
Closed
anoadragon453 wants to merge 1 commit intoold_masterfrom
Closed
MSC2425: Remove Authentication on /submitToken Identity Service API#2425anoadragon453 wants to merge 1 commit intoold_masterfrom
anoadragon453 wants to merge 1 commit intoold_masterfrom
Conversation
anoadragon453
force-pushed
the
anoa/no_auth_on_submit_token
branch
from
d6434ee to
564252b
Compare
anoadragon453
changed the title
Member
Author
|
Just testing mscbot :) @mscbot fcp cancel |
Collaborator
|
This proposal is not in FCP. |
turt2live
requested changes
Aug 26, 2020
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Otherwise lgtm. Like other MSCs, this needs a backwards compatibility section.
Comment on lines
+30
to
+31
| implementations of v2 3PID validation) already operate this way. The spec is | ||
| just wrong here. |
Member
There was a problem hiding this comment.
The spec is just wrong here
citation needed - please point to the MSC where the spec incorrectly inferred that authentication is required on these endpoints (which would make this MSC not needed) or remove this claim.
turt2live
added
the
needs-implementation
Member
|
This can be closed in the light of OIDC, can't it? |
Member
Author
Yes, you should add email addresses in your OIDC provider these days. Good catch! |
turt2live
added
the
obsolete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered