MSC2246: Asynchronous media uploads#2246
Merged
turt2live merged 30 commits intomatrix-org:old_masterfrom Apr 25, 2023
Merged
Conversation
Signed-off-by: Tulir Asokan <[email protected]>
Member
|
sounds excellent to me; would love to unblock streaming transfers at last. |
Signed-off-by: Tulir Asokan <[email protected]>
turt2live
previously requested changes
Aug 26, 2019
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
also generally looking in the right direction - I've left some early comments which are hopefully helpful.
Co-Authored-By: Travis Ralston <[email protected]>
|
The idea is then to send a media event, after the new /create endpoint, and before sending the media itself; isn't it? We have to consider the failure of the upload: it can lead to media event with eternal not found media. |
manuroe
reviewed
Aug 28, 2019
turt2live
changed the title
tulir
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
turt2live
added
the
needs-implementation
richvdh
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
May 3, 2023
Member
|
Merged 🎉 |
This was referenced May 4, 2023
12 tasks
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Jun 9, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
1 task
sumnerevans
added a commit
to beeper/complement
that referenced
this pull request
Jun 9, 2023
As of MSC2246 [1], the PUT method is allowed on the /_matrix/media/v3/upload endpoint. See the spec documentation here: https://spec.matrix.org/v1.7/client-server-api/#put_matrixmediav3uploadservernamemediaid [1]: matrix-org/matrix-spec-proposals#2246 Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Jun 9, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/complement
that referenced
this pull request
Jun 9, 2023
As of MSC2246 [1], the PUT method is allowed on the /_matrix/media/v3/upload endpoint. See the spec documentation here: https://spec.matrix.org/v1.7/client-server-api/#put_matrixmediav3uploadservernamemediaid [1]: matrix-org/matrix-spec-proposals#2246 Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Jun 9, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Jun 10, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Jun 10, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Aug 14, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Aug 14, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Aug 23, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Sep 5, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Sep 5, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
16 tasks
|
I know I'm very late, but it's surprising that nobody mentioned tus yet, which allows for resumable file uploads. Since the core is headers + |
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Oct 24, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Oct 24, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Oct 24, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Oct 24, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
added a commit
to beeper/synapse-legacy-fork
that referenced
this pull request
Oct 26, 2023
See matrix-org/matrix-spec-proposals#2246 for details Signed-off-by: Sumner Evans <[email protected]>
1 task
Contributor
|
For future code sleuths: Async uploads PR: matrix-org/synapse#15503 Released in Synapse: |
16 tasks
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
Signed-off-by: Tulir Asokan [email protected]
FCP Proposal