MSC1921: Support cancelling 3pid validation sessions#1921
Open
turt2live wants to merge 1 commit intoold_masterfrom
Open
MSC1921: Support cancelling 3pid validation sessions#1921turt2live wants to merge 1 commit intoold_masterfrom
turt2live wants to merge 1 commit intoold_masterfrom
Conversation
turt2live
added
proposal-in-review
proposal
turt2live
changed the title
Half-Shot
reviewed
Mar 8, 2019
| believed by the author that the additional security of ensuring the requester has permission to actually | ||
| cancel the session is more worthwhile than trying to fail fast. | ||
|
|
||
| Servers should also be aware of a potential resource exhaustion vector where an attacker requests a token and |
Contributor
There was a problem hiding this comment.
Definitely something that should happen during token creation, but I wouldn't rate limit cancelToken especially harshly.
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Mar 11, 2019
Fixes element-hq/element-web#6560 Would be better improved by matrix-org/matrix-spec-proposals#1921 or similar in the future.
Member
|
Is this still needed? Can we not just start another validation session and let the previous one eventually expire? |
Member
Author
|
There's a whole introduction that explains why this is needed and why letting them expire naturally is insufficient. This is still needed. |
turt2live
added
the
needs-implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
As mentioned in the introduction, this was written in the context of working on element-hq/element-web#6560.