Skip to content

Add proposal for invite error code for unsupported room version#1866

Merged
turt2live merged 1 commit intomasterfrom
erikj/fed_invite_error_code
Feb 25, 2019
Merged

Add proposal for invite error code for unsupported room version#1866
turt2live merged 1 commit intomasterfrom
erikj/fed_invite_error_code

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston commented Feb 8, 2019

No description provided.

@erikjohnston erikjohnston added the proposal A matrix spec change proposal label Feb 8, 2019
@erikjohnston erikjohnston changed the title Add proposal for invite error code Add proposal for invite error code for unsupported room version Feb 8, 2019
@turt2live turt2live added proposal-in-review c2s r0.5.0 Part of the r0.5.0 goal (and related releases) labels Feb 8, 2019
@erikjohnston
Copy link
Copy Markdown
Member Author

erikjohnston commented Feb 11, 2019

I think this is fairly uncontroversial, so may as well FCP it.

@mscbot fcp merge

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 11, 2019 •
edited by richvdh
Loading

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Feb 11, 2019
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 18, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Feb 23, 2019
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 23, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

This was referenced Feb 23, 2019
Merged
Open
@turt2live turt2live mentioned this pull request Feb 25, 2019
Closed
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Feb 25, 2019 •
edited
Loading

Implication of doing this is also that /createRoom can return the error code due to invites. I think this is fine as an extension, however.

Edit: Also, if I actually read the proposal before writing comments I would have realized that I'm speaking common sense...

@turt2live
Copy link
Copy Markdown
Member

turt2live commented Feb 25, 2019

also this had disposition merge...

@turt2live turt2live merged commit 23b2420 into master Feb 25, 2019
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period proposal-in-review labels Feb 25, 2019
turt2live added a commit that referenced this pull request Feb 25, 2019
@turt2live
Describe M_UNSUPPORTED_ROOM_VERSION on invite and createRoom endpoints
baf8948 
Spec for MSC1866: #1866
@turt2live turt2live mentioned this pull request Feb 25, 2019
Merged
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 25, 2019
@turt2live
Copy link
Copy Markdown
Member

turt2live commented Feb 25, 2019

Merged via #1908 🎉

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c2s r0.5.0 Part of the r0.5.0 goal (and related releases) disposition-merge kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikjohnston @mscbot @turt2live