Fix issue #7372, move widget functions into matplotlib.testing.widgets.#9905
Closed
dakotablair wants to merge 1 commit intomatplotlib:masterfrom
Closed
Fix issue #7372, move widget functions into matplotlib.testing.widgets.#9905dakotablair wants to merge 1 commit intomatplotlib:masterfrom
dakotablair wants to merge 1 commit intomatplotlib:masterfrom
Conversation
tacaswell
reviewed
Dec 1, 2017
| import mock | ||
|
|
||
|
|
||
| def get_ax(): |
Member
There was a problem hiding this comment.
I am 50/50 on moving this function.
Member
There was a problem hiding this comment.
Actually the name of this function does not reflect its body.
Member
There was a problem hiding this comment.
Then you should give it a better name in testing. I assume that functions defined in tests are not part of the public api. So this change would be matplotlib-internal.
SidharthBansal
added a commit
to SidharthBansal/matplotlib
that referenced
this pull request
Apr 4, 2020
…widgets. Thanks @dakotablair for their work in matplotlib#9905 Closes matplotlib#9905 Co-authored-by: @dakotablair
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix issue #7372, move widget functions into matplotlib.testing.widgets.
PR Checklist