Repository navigation
Deprecate column cycling when plot() inputs have nonmatching shapes. - #9826
Merged
Merged
Conversation
tacaswell
previously requested changes
Nov 23, 2017
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
👍 to deprecation, but needs api_changes docs.
anntzer
force-pushed
the
matching-column-plots
branch
from
November 23, 2017 21:08
2fdfbdf to
503af4b
Compare
Contributor
Author
|
done |
Member
|
Oh... except there is no test for this. Not sure how one tests deprecation warnings. But it'd be good to have a test in place for when this will cause an error... |
Currently, something like
plot([[0, 1, 2], [3, 4, 5]], [[0, 1], [2, 3]])
will plot column 0 of x vs column 0 of y; column 1 of x vs column 1 of
y; and column 2 of x vs column 1 of y (i.e. cycle among columns). This
behavior appears to be error-prone to say the least.
Note that "normal" broadcasting (1->n) is not deprecated.
anntzer
force-pushed
the
matching-column-plots
branch
from
November 24, 2017 19:54
503af4b to
d9545b3
Compare
Contributor
Author
|
test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, something like
will plot column 0 of x vs column 0 of y; column 1 of x vs column 1 of
y; and column 2 of x vs column 1 of y (i.e. cycle among columns). This
behavior appears to be error-prone to say the least.
Note that "normal" broadcasting (1->n) is not deprecated.
Closes #9784.
PR Summary
PR Checklist