Skip to content

Clean up Appveyor config file - #9319

Closed
dstansby wants to merge 2 commits into
matplotlib:masterfrom
dstansby:appveyor-clean
Closed

dstansby wants to merge 2 commits into
matplotlib:masterfrom
dstansby:appveyor-clean

Conversation

@dstansby

@dstansby dstansby commented Oct 8, 2017 •

Copy link
Copy Markdown
Member

There have been a few problems with Appveyor recently; this attempts to clean up the initial stages of the testing a bit to help diagnose and speed up.

(nb. I'm pushing this one commit at a time to check they individually don't break the build)

@dstansby
dstansby force-pushed the appveyor-clean branch 2 times, most recently from e463697 to 3e16a3b Compare October 9, 2017 19:27
@dstansby dstansby changed the title [WIP] Clean up Appveyor config file Clean up Appveyor config file Oct 10, 2017
@dstansby

Copy link
Copy Markdown
Member Author

This should speed up appveyor by a little bit by removing 1 call to conda

@dstansby dstansby added this to the 2.2 (next feature release) milestone Oct 10, 2017
Comment thread .appveyor.yml Outdated
- conda install -c conda-forge --yes obvious-ci
- conda config --set always_yes true
- conda update --all
- conda install anaconda-client=1.6.3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should be removed completely because previously anaconda-client were upgraded to newer version by next line edited by you.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think that's because other versions of anadonda-client were breaking stuff? I can try removing the line and seeing what happens.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only three lines are now executed under anaconda-client=1.6.3

conda config --prepend channels conda-forge
conda config --set show_channel_urls yes
conda config --set always_yes true

I do not think it does matter at all. So removing the line must not change anything.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right. Some dependency hell is going here.

@dstansby

Copy link
Copy Markdown
Member Author

Okay, I've re-pinned anaconda-build and just added it to the line where everything is installed by conda.

Comment thread .appveyor.yml
- echo %PYTHON_VERSION% %TARGET_ARCH%
# pytest-cov>=2.3.1 due to https://github.com/pytest-dev/pytest-cov/issues/124
- pip install -q pytest "pytest-cov>=2.3.1" pytest-rerunfailures pytest-timeout pytest-xdist
cycler pyparsing backports.functools-lru-cache

@dstansby dstansby Nov 14, 2017 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting these in this "quiet" pip section (instead of installing them along with Matplotlib later) should shave a few hundred useless lines from the output log.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages will be installed automatically (#9673).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but they're installed at the same time as Matplotlib, which I don't think we want to have a quiet flag. Putting them here prevents pip spewing out a load of extra lines that aren't very useful for debugging.

@dstansby

Copy link
Copy Markdown
Member Author

I think this has all been covered by #9773

@dstansby dstansby closed this Nov 25, 2017
@dstansby
dstansby deleted the appveyor-clean branch November 25, 2017 12:09
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants