Repository navigation
colorbar: update to work with #901 (41fcab53) - #929
Merged
Merged
Conversation
edgecolors='None' now must be included explicitly. Even if this change in the default is reverted, it makes sense for colorbar to be explicit about it.
Member
|
Changing the default behavior was unintentional. This is a good argument for having a test case to catch this. As you say, this is a good change to have in any case, but I think I'll also try to fix pcolormesh so it has the old default behavior for edgecolors. Do you agree? |
Member
Author
|
On 06/06/2012 09:48 AM, Michael Droettboom wrote:
Yes on both counts! |
mdboom
added a commit
to mdboom/matplotlib
that referenced
this pull request
Jun 7, 2012
…b#929. The default behavior of pcolormesh should be to draw no edges if no `edgecolors` kwarg is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edgecolors='None' now must be included explicitly. Even if
this change in the default is reverted, it makes sense for
colorbar to be explicit about it.