Skip to content

pgf: Fix invalid arguments passed to pdftocairo. - #8127

Merged
tacaswell merged 1 commit into
matplotlib:v2.0.xfrom
QuLogic:fix-pgf-to-png
Feb 22, 2017
Merged

tacaswell merged 1 commit into
matplotlib:v2.0.xfrom
QuLogic:fix-pgf-to-png

Conversation

@QuLogic

@QuLogic QuLogic commented Feb 22, 2017

Copy link
Copy Markdown
Member

This breaks saving PNG when using the PGF backend.

Fixes #8121.

This breaks saving PNG when using the PGF backend.

Fixes matplotlib#8121.
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Feb 22, 2017
@tacaswell

Copy link
Copy Markdown
Member

The only non-whitespace change is to drop shell=True?

@QuLogic

QuLogic commented Feb 22, 2017 •

Copy link
Copy Markdown
Member Author

To split "-r %d" into two arguments (shell=True was only necessary because of it, but didn't seem to work any more.)

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anntzer anntzer changed the title pgf: Fix invalid arguments passed to pdftocairo. [MRG+1] pgf: Fix invalid arguments passed to pdftocairo. Feb 22, 2017
@tacaswell
tacaswell merged commit bef5a8e into matplotlib:v2.0.x Feb 22, 2017
@QuLogic
QuLogic deleted the fix-pgf-to-png branch February 22, 2017 06:06
@QuLogic QuLogic changed the title [MRG+1] pgf: Fix invalid arguments passed to pdftocairo. pgf: Fix invalid arguments passed to pdftocairo. Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants